From reviews-return-88723-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Jul 9 00:24:53 2019 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id CBB5E19AED for ; Tue, 9 Jul 2019 00:24:52 +0000 (UTC) Received: (qmail 32331 invoked by uid 500); 9 Jul 2019 00:24:51 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 32306 invoked by uid 500); 9 Jul 2019 00:24:51 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 32289 invoked by uid 99); 9 Jul 2019 00:24:51 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Jul 2019 00:24:51 +0000 Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 114ABE00A6; Tue, 9 Jul 2019 00:24:51 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id E75AAC4008B; Tue, 9 Jul 2019 00:24:50 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1034185599904234596==" MIME-Version: 1.0 Subject: Re: Review Request 71029: Added Role::quotaConsumption to the master. From: Meng Zhu To: Meng Zhu , Andrei Sekretenko Cc: Benjamin Mahler , mesos Date: Tue, 09 Jul 2019 00:24:50 -0000 Message-ID: <20190709002450.23452.53364@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Meng Zhu X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/71029/ X-Sender: Meng Zhu References: <20190708180731.23452.35661@reviews-vm2.apache.org> In-Reply-To: <20190708180731.23452.35661@reviews-vm2.apache.org> Reply-To: Meng Zhu X-ReviewRequest-Repository: mesos --===============1034185599904234596== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71029/#review216436 ----------------------------------------------------------- src/master/master.hpp Lines 2714-2715 (patched) If we want to expose the composition, reserved unused, unreserved used and etc. We probably want to split this into several functions? e.g. allocation(), reservation(), used_reservaiton() and then combine as needed in the endpoint handler. - Meng Zhu On July 8, 2019, 11:07 a.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71029/ > ----------------------------------------------------------- > > (Updated July 8, 2019, 11:07 a.m.) > > > Review request for mesos, Andrei Sekretenko and Meng Zhu. > > > Bugs: MESOS-9871 > https://issues.apache.org/jira/browse/MESOS-9871 > > > Repository: mesos > > > Description > ------- > > Quota consumption is computed as follows: > > Allocation + Unallocated Reservation == > Reservations + Unreserved Allocation > > That is, reservations count towards quota regardless of whether > they're allocated. Allocation counts towards quota. Offered resources > *do not* count towards quota, this is to (1) provide stability of the > quota consumption metrics in the face of offers flowing in and out, > and (2) to ensure that we treat offers as rescindable and therefore > not yet "counting" towards quota. Also, if in the future schedulers > are offered more than their quota to improve their choices, counting > offered resources as quota consumption will be problematic. > > > Diffs > ----- > > src/master/framework.cpp c35de2574ef683a9f397a957422fdbf8fa751313 > src/master/master.hpp 23dafe746b6f9b3d70ad7220f54c4d49068b8af8 > > > Diff: https://reviews.apache.org/r/71029/diff/1/ > > > Testing > ------- > > Added a test in a subsequent patch. > > > Thanks, > > Benjamin Mahler > > --===============1034185599904234596==--