From reviews-return-88746-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Jul 10 01:20:24 2019 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id BC41019FB8 for ; Wed, 10 Jul 2019 01:20:23 +0000 (UTC) Received: (qmail 7084 invoked by uid 500); 10 Jul 2019 01:20:23 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 7048 invoked by uid 500); 10 Jul 2019 01:20:23 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 6973 invoked by uid 99); 10 Jul 2019 01:20:22 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Jul 2019 01:20:22 +0000 Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D9941E2B40; Wed, 10 Jul 2019 01:20:21 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id BD4BEC40060; Wed, 10 Jul 2019 01:20:21 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3701434549550783007==" MIME-Version: 1.0 Subject: Re: Review Request 71032: Added a test for /roles quota.consumed field. From: Benjamin Mahler To: Meng Zhu , Andrei Sekretenko Cc: Mesos Reviewbot , Benjamin Mahler , mesos Date: Wed, 10 Jul 2019 01:20:21 -0000 Message-ID: <20190710012021.8899.19089@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Benjamin Mahler X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/71032/ X-Sender: Benjamin Mahler References: <20190708180734.23452.37668@reviews-vm2.apache.org> In-Reply-To: <20190708180734.23452.37668@reviews-vm2.apache.org> Reply-To: Benjamin Mahler X-ReviewRequest-Repository: mesos --===============3701434549550783007== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71032/ ----------------------------------------------------------- (Updated July 10, 2019, 1:20 a.m.) Review request for mesos, Andrei Sekretenko and Meng Zhu. Changes ------- - Updated to use new endpoint format. Summary (updated) ----------------- Added a test for /roles quota.consumed field. Bugs: MESOS-9871 https://issues.apache.org/jira/browse/MESOS-9871 Repository: mesos Description ------- This ensures that the various edge different states of resources are correctly handled, see test comment for more details. Diffs (updated) ----- src/tests/role_tests.cpp bf5b3cba59d38eee41ed222d14bc8c928fcf2a79 Diff: https://reviews.apache.org/r/71032/diff/2/ Changes: https://reviews.apache.org/r/71032/diff/1-2/ Testing ------- Ran 1000 times in repetition. Thanks, Benjamin Mahler --===============3701434549550783007==--