From reviews-return-89068-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Jul 23 16:21:32 2019 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id 1020F18367 for ; Tue, 23 Jul 2019 16:21:31 +0000 (UTC) Received: (qmail 46298 invoked by uid 500); 23 Jul 2019 16:21:31 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 46270 invoked by uid 500); 23 Jul 2019 16:21:31 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 46253 invoked by uid 99); 23 Jul 2019 16:21:31 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 23 Jul 2019 16:21:31 +0000 Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 81D64E2800; Tue, 23 Jul 2019 16:21:30 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 65601C41565; Tue, 23 Jul 2019 16:21:30 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2611347125157175675==" MIME-Version: 1.0 Subject: Re: Review Request 71130: Added a test to ensure allocations are restricted by quota limits. From: Benjamin Mahler To: Benjamin Mahler , Andrei Sekretenko Cc: Meng Zhu , mesos Date: Tue, 23 Jul 2019 16:21:30 -0000 Message-ID: <20190723162130.57127.23891@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Benjamin Mahler X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/71130/ X-Sender: Benjamin Mahler X-ReviewBoard-ShipIt: 1 References: <20190719213246.20115.84882@reviews-vm2.apache.org> In-Reply-To: <20190719213246.20115.84882@reviews-vm2.apache.org> Reply-To: Benjamin Mahler X-ReviewRequest-Repository: mesos --===============2611347125157175675== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71130/#review216803 ----------------------------------------------------------- Fix it, then Ship it! src/tests/hierarchical_allocator_tests.cpp Lines 3573-3575 (patched) There needs to be a settle before this to make sure the addSlave call completed executing? As an aside, it would be nice if we surfaced the Futures from these calls (e.g. addSlave) rather than hiding them with a void return type. Then we could just AWAIT_READY here instead of settling. src/tests/hierarchical_allocator_tests.cpp Lines 3588-3589 (patched) "Now raise the limit from 0 to ... which should make the role get resources up to this limit" ? src/tests/hierarchical_allocator_tests.cpp Lines 3627-3628 (patched) use `*` operator instead of .get() here and above? - Benjamin Mahler On July 19, 2019, 9:32 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71130/ > ----------------------------------------------------------- > > (Updated July 19, 2019, 9:32 p.m.) > > > Review request for mesos, Andrei Sekretenko and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Added a test to ensure allocations are restricted by quota limits. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp 9ebeeb6501e909544f5461710059ded66fb70eed > > > Diff: https://reviews.apache.org/r/71130/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > > --===============2611347125157175675==--