From reviews-return-89090-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Jul 24 13:35:12 2019 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id 4E58619403 for ; Wed, 24 Jul 2019 13:35:12 +0000 (UTC) Received: (qmail 3477 invoked by uid 500); 24 Jul 2019 13:35:11 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 3457 invoked by uid 500); 24 Jul 2019 13:35:11 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 3435 invoked by uid 99); 24 Jul 2019 13:35:11 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 24 Jul 2019 13:35:11 +0000 Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id A45FDE02E6; Wed, 24 Jul 2019 13:35:07 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 82C43C419C4; Wed, 24 Jul 2019 13:35:07 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0951127257151673838==" MIME-Version: 1.0 Subject: Re: Review Request 71082: Added a helper to create std::vector from iterable into python bindings. From: Andrei Sekretenko To: Meng Zhu , Benjamin Mahler Cc: Andrei Sekretenko , mesos Date: Wed, 24 Jul 2019 13:35:07 -0000 Message-ID: <20190724133507.58558.18892@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Andrei Sekretenko X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/71082/ X-Sender: Andrei Sekretenko References: <20190723213505.57128.82671@reviews-vm2.apache.org> In-Reply-To: <20190723213505.57128.82671@reviews-vm2.apache.org> Reply-To: Andrei Sekretenko X-ReviewRequest-Repository: mesos --===============0951127257151673838== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On July 23, 2019, 9:35 p.m., Benjamin Mahler wrote: > > src/python/native_common/common.hpp > > Lines 155-159 (patched) > > > > > > Is this still needed? Looks like a declaration of the definition above? No, this is a different template declaration, and it is not redundant. For non-protobufs, `enable_if<...>::type` does not exist. Thus, the first one is a *substitution failure* for non-protobufs, and we need another template declaration for them (which should be a substitution falure for protobufs, otherwise we get two conflicting declarations - hence the second `enable_if`). - Andrei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71082/#review216818 ----------------------------------------------------------- On July 24, 2019, 1:34 p.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71082/ > ----------------------------------------------------------- > > (Updated July 24, 2019, 1:34 p.m.) > > > Review request for mesos, Benjamin Mahler and Meng Zhu. > > > Bugs: MESOS-9864 > https://issues.apache.org/jira/browse/MESOS-9864 > > > Repository: mesos > > > Description > ------- > > Added a helper to create std::vector from iterable into python bindings. > > > Diffs > ----- > > src/python/native_common/common.hpp ed743aab014301981fe2526a7e81f4a35c02e19b > > > Diff: https://reviews.apache.org/r/71082/diff/3/ > > > Testing > ------- > > With valid arguments - see next patches. > Ran with invalid arguments manually. > > > Thanks, > > Andrei Sekretenko > > --===============0951127257151673838==--