From reviews-return-89103-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Jul 25 01:55:31 2019 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id CAC691939F for ; Thu, 25 Jul 2019 01:55:30 +0000 (UTC) Received: (qmail 93157 invoked by uid 500); 25 Jul 2019 01:55:30 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 93118 invoked by uid 500); 25 Jul 2019 01:55:30 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 93101 invoked by uid 99); 25 Jul 2019 01:55:29 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 Jul 2019 01:55:29 +0000 Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 21D19E0E1C; Thu, 25 Jul 2019 01:55:29 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 059EBC4008A; Thu, 25 Jul 2019 01:55:29 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8487282506818556929==" MIME-Version: 1.0 Subject: Review Request 71159: Updated quota related endpoints to return quota configurations. From: Meng Zhu To: Benjamin Mahler , Andrei Sekretenko Cc: Meng Zhu , mesos Date: Thu, 25 Jul 2019 01:55:29 -0000 Message-ID: <20190725015529.58558.56569@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Meng Zhu X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/71159/ X-Sender: Meng Zhu Reply-To: Meng Zhu X-ReviewRequest-Repository: mesos --===============8487282506818556929== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71159/ ----------------------------------------------------------- Review request for mesos, Andrei Sekretenko and Benjamin Mahler. Bugs: MESOS-9598 and MESOS-9599 https://issues.apache.org/jira/browse/MESOS-9598 https://issues.apache.org/jira/browse/MESOS-9599 Repository: mesos Description ------- Added quota configuration information (that includes both guarantees and limits) in V1 GET_QUOTA call and V0 GET "/quota". To keep backwards compatibility, the infos field which only includes the guarantees are continue to be filled. An additional field configs was added. Also extended an existing test to cover the changes in the endpoints. Diffs ----- src/master/quota_handler.cpp 15b02b08917201c824230d649fdae265957748af src/tests/master_quota_tests.cpp 7745fb0a903c4dc5603c12049f224b3d45273a4b Diff: https://reviews.apache.org/r/71159/diff/1/ Testing ------- make check Thanks, Meng Zhu --===============8487282506818556929==--