From reviews-return-89125-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Jul 26 04:35:34 2019 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id 2ADFB19F89 for ; Fri, 26 Jul 2019 04:35:34 +0000 (UTC) Received: (qmail 88290 invoked by uid 500); 26 Jul 2019 04:35:33 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 88232 invoked by uid 500); 26 Jul 2019 04:35:33 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 88212 invoked by uid 99); 26 Jul 2019 04:35:33 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 26 Jul 2019 04:35:33 +0000 Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 8B71BE0E1C; Fri, 26 Jul 2019 04:35:32 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 573AAC4014C; Fri, 26 Jul 2019 04:35:32 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5330093186149355869==" MIME-Version: 1.0 Subject: Re: Review Request 71146: Clarified a comment in storage local resource provider tests. From: Chun-Hung Hsiao To: Chun-Hung Hsiao Cc: Benjamin Bannier , mesos Date: Fri, 26 Jul 2019 04:35:32 -0000 Message-ID: <20190726043532.62588.26999@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Chun-Hung Hsiao X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/71146/ X-Sender: Chun-Hung Hsiao X-ReviewBoard-ShipIt: 1 References: <20190723201812.57127.45526@reviews-vm2.apache.org> In-Reply-To: <20190723201812.57127.45526@reviews-vm2.apache.org> Reply-To: Chun-Hung Hsiao X-ReviewRequest-Repository: mesos --===============5330093186149355869== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71146/#review216875 ----------------------------------------------------------- Fix it, then Ship it! src/tests/storage_local_resource_provider_tests.cpp Line 615 (original), 615 (patched) The RP "daemon" does not "get subscribed." The RP daemon is started after agent registration, which instantiate the resource providers, which subscribes to the RP manager. So maybe "Since the local resource provider gets subscribed after the agent is registered?" Ditto below. - Chun-Hung Hsiao On July 23, 2019, 8:18 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71146/ > ----------------------------------------------------------- > > (Updated July 23, 2019, 8:18 p.m.) > > > Review request for mesos and Chun-Hung Hsiao. > > > Bugs: MESOS-9254 > https://issues.apache.org/jira/browse/MESOS-9254 > > > Repository: mesos > > > Description > ------- > > Clarified a comment in storage local resource provider tests. > > > Diffs > ----- > > src/tests/storage_local_resource_provider_tests.cpp 69861265d94ddf344da96b593797ce145394413e > > > Diff: https://reviews.apache.org/r/71146/diff/1/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > > --===============5330093186149355869==--