mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [mesos] ArmandGrillet commented on a change in pull request #345: Allow `mesos task exec/attach` for any task_id
Date Fri, 25 Oct 2019 06:56:56 GMT
ArmandGrillet commented on a change in pull request #345: Allow `mesos task exec/attach` for
any task_id
URL: https://github.com/apache/mesos/pull/345#discussion_r338904665
 
 

 ##########
 File path: src/python/cli_new/lib/cli/http.py
 ##########
 @@ -41,6 +41,8 @@ def read_endpoint(addr, endpoint):
 
     try:
         url = "{addr}/{endpoint}".format(addr=addr, endpoint=endpoint)
+        if query is not None:
+          url += "?{query}".format(query=urllib.parse.urlencode(query))
 
 Review comment:
   Query parameters being common in the HTTP endpoints, having the ability to add some when
reading an endpoint makes sense ✅.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message