mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Re: Review Request 71490: Added quota consumption metrics to the hierarchial allocator.
Date Wed, 02 Oct 2019 20:13:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71490/#review218033
-----------------------------------------------------------


Fix it, then Ship it!





src/master/allocator/mesos/hierarchical.hpp
Lines 134 (patched)
<https://reviews.apache.org/r/71490/#comment305509>

    I am not sure if returning const Value is a good idea. e.g. does it prevent rvalue optimization?


- Meng Zhu


On Sept. 18, 2019, 10:13 a.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71490/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2019, 10:13 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Meng Zhu.
> 
> 
> Bugs: MESOS-9123
>     https://issues.apache.org/jira/browse/MESOS-9123
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added quota consumption metrics to the hierarchial allocator.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.hpp d42124f534536ad044bff9878d242892fa042f24

>   src/master/allocator/mesos/hierarchical.cpp 47281542792486854b71c7e75dfa8ea3ee3ef3fc

>   src/master/allocator/mesos/metrics.hpp adb9515c82029f32e57e73cddd441c1bceec1aee 
>   src/master/allocator/mesos/metrics.cpp ba95dc4415e3f85522f5d1291b6e9c171b900482 
> 
> 
> Diff: https://reviews.apache.org/r/71490/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message