mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Review Request 71579: Eliminate accidental loop amplification over unreachable tasks.
Date Thu, 03 Oct 2019 20:59:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71579/
-----------------------------------------------------------

Review request for mesos, haosdent huang and Meng Zhu.


Bugs: MESOS-9889
    https://issues.apache.org/jira/browse/MESOS-9889


Repository: mesos


Description
-------

Per MESOS-9889, the foreachkey operator on a multimap will actually
loop over each <key,value> entry, thus looping over the same key
multiple times. The code in the master is written such that
excessive looping occurs.

For example: <F1,T1> <F1,T2> <F1,T3>
This will consider T1,T2,T3 3 times each rather than once each!


Diffs
-----

  src/master/master.hpp 23eb2a6854b1b53f80167cc8425339530de78e81 
  src/master/master.cpp 65994aa72ec4bfefdb09b88a62db910727bb0897 


Diff: https://reviews.apache.org/r/71579/diff/1/


Testing
-------

make check


Thanks,

Benjamin Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message