mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@mesosphere.io>
Subject Re: Review Request 71489: Replaced removal+adding of quota metrics with updating them.
Date Fri, 04 Oct 2019 18:30:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71489/
-----------------------------------------------------------

(Updated Oct. 4, 2019, 6:30 p.m.)


Review request for mesos, Benjamin Mahler and Meng Zhu.


Bugs: MESOS-9123
    https://issues.apache.org/jira/browse/MESOS-9123


Repository: mesos


Description
-------

This patch factor out the common code for updating quota guarantee
and quota limit metrics, and replaces pairs of
`process::metrics::remove()`/`process::metrics::add()` called for the
same metric with calling `PushGauge::operator = ()`. This is
a perequisite for adding PushGauge-based quota consumption metrics.


Diffs (updated)
-----

  src/master/allocator/mesos/metrics.hpp adb9515c82029f32e57e73cddd441c1bceec1aee 
  src/master/allocator/mesos/metrics.cpp ba95dc4415e3f85522f5d1291b6e9c171b900482 


Diff: https://reviews.apache.org/r/71489/diff/3/

Changes: https://reviews.apache.org/r/71489/diff/2-3/


Testing
-------


Thanks,

Andrei Sekretenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message