mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Review Request 71597: Rejected invalid quota configs from registry operation.
Date Wed, 09 Oct 2019 04:43:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71597/
-----------------------------------------------------------

Review request for mesos, Andrei Sekretenko and Meng Zhu.


Bugs: MESOS-10008
    https://issues.apache.org/jira/browse/MESOS-10008


Repository: mesos


Description
-------

The registry operation for updating quota was assuming that
the quota configs were valid. This validates them and fails
the operation if invalid. Note that the caller should be
validating this already, but this serves as an extra guard.


Diffs
-----

  src/master/quota.cpp 4ecd3269ac092b187082675e723cb18e40cea573 


Diff: https://reviews.apache.org/r/71597/diff/1/


Testing
-------

Test added in subsequent patch.


Thanks,

Benjamin Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message