mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 71608: WIP: Supported destroying UCR container in `PROVISIONING` state.
Date Mon, 14 Oct 2019 20:28:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71608/#review218206
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/containerizer/mesos/provisioner/docker/store.cpp
Lines 296-312 (patched)
<https://reviews.apache.org/r/71608/#comment305780>

    could you just do:
    
    ```
    promise->associate(future);
    
    return promise->future()
      .onDiscard([promise]() {
        promise->discard();
      });
    ```



src/slave/containerizer/mesos/provisioner/provisioner.hpp
Lines 189 (patched)
<https://reviews.apache.org/r/71608/#comment305779>

    smart move! we decouple the destroy from image pulling to avoid a write lock!



src/slave/containerizer/mesos/provisioner/provisioner.cpp
Line 521 (original), 522 (patched)
<https://reviews.apache.org/r/71608/#comment305778>

    Just double checking: once we discard the store::get() above, this .then will not continue?


- Gilbert Song


On Oct. 14, 2019, 7:50 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71608/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2019, 7:50 a.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-9964
>     https://issues.apache.org/jira/browse/MESOS-9964
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> WIP: Supported destroying UCR container in `PROVISIONING` state.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.hpp 6537f6550b353b1c65a30381f6d68f61508d4960

>   src/slave/containerizer/mesos/containerizer.cpp c61b954635ebcaed3e498452bddeee6e1b34f388

>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 286ee5f00933b4c86a96dc4e10e42f9e7eac0ce2

>   src/slave/containerizer/mesos/provisioner/provisioner.hpp 38664177ae3805041b412ed52dd0134a6f3aa679

>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 3d0b291fa878ab22625435afe2a219d6f776e52c

>   src/tests/containerizer/provisioner_docker_tests.cpp 5d5a355afd9c4fda1c653d6cecb75703b0f2222e

>   src/uri/fetchers/docker.cpp 8f5fc964f056b349ce57ced139e07f538cb1cfd2 
> 
> 
> Diff: https://reviews.apache.org/r/71608/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message