mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 71629: Improved logging in Docker store and registry puller.
Date Thu, 17 Oct 2019 18:50:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71629/#review218275
-----------------------------------------------------------




src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp
Lines 457-458 (original), 456-457 (patched)
<https://reviews.apache.org/r/71629/#comment305919>

    Is this too verbose? 
    
    Each image may have 100 lines of this log



src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp
Lines 533-534 (original), 532-533 (patched)
<https://reviews.apache.org/r/71629/#comment305920>

    ditto



src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp
Lines 544-545 (original), 543-544 (patched)
<https://reviews.apache.org/r/71629/#comment305921>

    ditto



src/slave/containerizer/mesos/provisioner/docker/store.cpp
Lines 358 (patched)
<https://reviews.apache.org/r/71629/#comment305922>

    we probably want to log this line in metadatamanager?


- Gilbert Song


On Oct. 17, 2019, 2:45 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71629/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2019, 2:45 a.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-9964
>     https://issues.apache.org/jira/browse/MESOS-9964
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Improved logging in Docker store and registry puller.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 35b6afbb6b22575b90963927352443a8ddaf9885

>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 286ee5f00933b4c86a96dc4e10e42f9e7eac0ce2

> 
> 
> Diff: https://reviews.apache.org/r/71629/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message