mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 71664: SSL Wrapper: Implemented BIO for SSL socket wrapper.
Date Thu, 31 Oct 2019 01:29:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71664/
-----------------------------------------------------------

(Updated Oct. 30, 2019, 6:29 p.m.)


Review request for mesos, Benno Evers, Benjamin Mahler, Greg Mann, and Till Toenshoff.


Changes
-------

Reimplemented bio_libprocess_write and bio_libprocess_read to surface backpressure to the
client/peer.  Instead of having a read loop, we simply buffer a single read at once.  And
instead of queueing all writes indiscriminately, we only allow one pending write at once.


Bugs: MESOS-10009
    https://issues.apache.org/jira/browse/MESOS-10009


Repository: mesos


Description
-------

This implements the OpenSSL basic I/O abstraction based on the
libprocess event loop.  This BIO wraps a socket and handles the
reading/writing, using io::read and io::write.

This BIO can be passed into an SSL context to enable usage of
SSL translation functions like SSL_read and SSL_write.


Diffs (updated)
-----

  3rdparty/libprocess/src/ssl/socket_wrapper.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/71664/diff/2/

Changes: https://reviews.apache.org/r/71664/diff/1-2/


Testing
-------

cmake --build . --target process

A tiny bit of testing next patch.


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message