mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 71666: WIP: SSL Wrapper: Implemented send/recv and shutdown.
Date Thu, 31 Oct 2019 01:35:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71666/
-----------------------------------------------------------

(Updated Oct. 30, 2019, 6:35 p.m.)


Review request for mesos, Benno Evers, Benjamin Mahler, Greg Mann, and Till Toenshoff.


Bugs: MESOS-10010
    https://issues.apache.org/jira/browse/MESOS-10010


Repository: mesos


Description
-------

This completes a fully functional client-side SSL socket.

Needs a bit of cleanup and more error handling though.


Diffs (updated)
-----

  3rdparty/libprocess/src/ssl/socket_wrapper.hpp PRE-CREATION 
  3rdparty/libprocess/src/ssl/socket_wrapper.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/71666/diff/2/

Changes: https://reviews.apache.org/r/71666/diff/1-2/


Testing (updated)
-------

Successfully fetched from a webpage:
```
  http::URL url = http::URL(
     "https",
     "www.google.com",
     443);

  Future<http::Response> response = http::get(url);
  AWAIT_READY(response);
  EXPECT_EQ(http::Status::OK, response->code);
```

Running libprocess-tests yields:
```
[  FAILED  ] SSLTest.SilentSocket (hangs indefinitely)
[  FAILED  ] SSLTest.ValidDowngrade
[  FAILED  ] SSLTest.ValidDowngradeEachProtocol
[  FAILED  ] SSLTest.ShutdownThenSend
```


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message