mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [mesos] greggomann commented on a change in pull request #363: CMake enable install module dependencies.
Date Wed, 13 May 2020 19:27:19 GMT

greggomann commented on a change in pull request #363:
URL: https://github.com/apache/mesos/pull/363#discussion_r424678947



##########
File path: 3rdparty/CMakeLists.txt
##########
@@ -99,6 +99,12 @@ else ()
   set(LIBRARY_SUFFIX ${CMAKE_STATIC_LIBRARY_SUFFIX})
 endif ()
 
+if (WIN32 AND BUILD_SHARED_LIBS)
+  set(3RDPARTY_LIBS_INSTALL_DIR ${MESOS_INSTALL_RUNTIME})
+else()
+  set(3RDPARTY_LIBS_INSTALL_DIR ${MESOS_INSTALL_LIBRARIES})
+endif()
+

Review comment:
       It looks like @asekretenko already incorporated the 3 commits from this PR that you
mentioned, except for the addition of the `.jar` files to the installation. Andrei, is there
a reason not to include the JARs?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message