mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [mesos] akornatskyy commented on a change in pull request #363: CMake enable install module dependencies.
Date Thu, 14 May 2020 07:46:21 GMT

akornatskyy commented on a change in pull request #363:
URL: https://github.com/apache/mesos/pull/363#discussion_r424934740



##########
File path: 3rdparty/CMakeLists.txt
##########
@@ -512,6 +523,11 @@ ExternalProject_Add(
   URL               ${RAPIDJSON_URL}
   URL_HASH          ${RAPIDJSON_HASH})
 
+if (ENABLE_INSTALL_MODULE_DEPENDENCIES)
+  install(
+    DIRECTORY ${RAPIDJSON_CMAKE_ROOT}/src/rapidjson-${RAPIDJSON_VERSION}/include
+    DESTINATION .)

Review comment:
       Here is a list of *autotools* build directories for `include`:
   ```
   csi elfio mesos process rapidjson stout picojson.h
   ```
   and `lib/mesos/3rdparty/include`:
   ```
   elfio glog google nvidia rapidjson zookeeper concurrentqueue.h picojson.h
   ```
   As you can observe there are duplicates and inconsistency.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message