mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [mesos] akornatskyy commented on a change in pull request #363: CMake enable install module dependencies.
Date Tue, 19 May 2020 13:44:10 GMT

akornatskyy commented on a change in pull request #363:
URL: https://github.com/apache/mesos/pull/363#discussion_r427312989



##########
File path: 3rdparty/CMakeLists.txt
##########
@@ -459,6 +459,11 @@ install(
   DIRECTORY ${GLOG_INSTALL_DIR}/lib/
   DESTINATION ${MESOS_INSTALL_LIBRARIES})
 
+if (ENABLE_INSTALL_MODULE_DEPENDENCIES)
+  install(
+    DIRECTORY ${GLOG_INSTALL_DIR}/include
+    DESTINATION ${MESOS_INSTALL_LIBRARIES}/mesos/3rdparty)
+endif ()

Review comment:
       `install(TARGETS ...)` can be [configured](https://cmake.org/cmake/help/v3.13/command/install.html#installing-targets)
with headers, if target defines [PUBLIC_HEADER](https://cmake.org/cmake/help/v3.13/prop_tgt/PUBLIC_HEADER.html#prop_tgt:PUBLIC_HEADER)
or [PRIVATE_HEADER](https://cmake.org/cmake/help/v3.13/prop_tgt/PRIVATE_HEADER.html#prop_tgt:PRIVATE_HEADER).
anyway you need to enumerate either with `PUBLIC_HEADER`, `PRIVATE_HEADER`, in `install(DIRECTORY
...)` or in `install(FILES ...)`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message