mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [mesos] asekretenko commented on a change in pull request #363: CMake enable install module dependencies.
Date Mon, 25 May 2020 07:10:26 GMT

asekretenko commented on a change in pull request #363:
URL: https://github.com/apache/mesos/pull/363#discussion_r429766695



##########
File path: src/CMakeLists.txt
##########
@@ -675,6 +675,13 @@ install(
   RUNTIME DESTINATION ${MESOS_INSTALL_RUNTIME}
   ARCHIVE DESTINATION ${MESOS_INSTALL_LIBRARIES}
   LIBRARY DESTINATION ${MESOS_INSTALL_LIBRARIES})
+install(
+    DIRECTORY
+      ${CMAKE_SOURCE_DIR}/3rdparty/libprocess/include
+      ${CMAKE_SOURCE_DIR}/3rdparty/stout/include

Review comment:
       This PR moves libprocess libraries install into CMakeLists.txt of libprocess: https://reviews.apache.org/r/72493/

   (`LIBPROCESS_INSTALL_*` are introduced by the preceding one: https://reviews.apache.org/r/72492/)
   
   I have the current state of both PRs mirrored in https://github.com/asekretenko/mesos/tree/cmake_install_step_3.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message