mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [mesos] asekretenko commented on a change in pull request #363: CMake enable install module dependencies.
Date Mon, 25 May 2020 07:30:51 GMT

asekretenko commented on a change in pull request #363:
URL: https://github.com/apache/mesos/pull/363#discussion_r429774545



##########
File path: 3rdparty/CMakeLists.txt
##########
@@ -459,6 +459,11 @@ install(
   DIRECTORY ${GLOG_INSTALL_DIR}/lib/
   DESTINATION ${MESOS_INSTALL_LIBRARIES})
 
+if (ENABLE_INSTALL_MODULE_DEPENDENCIES)
+  install(
+    DIRECTORY ${GLOG_INSTALL_DIR}/include
+    DESTINATION ${MESOS_INSTALL_LIBRARIES}/mesos/3rdparty)
+endif ()

Review comment:
       I don't think defining `PUBLIC_HEADER`/`PRIVATE_HEADER` for mesos/stout/libprocess
at this point makes sense. This will require either specifying them manually, or enumerating
via something like `files(GLOB ...)`; I don't see how this can add any value now. This can
be done in future if needed.
   
   And there seems to be no way to make `ExternalProject` define `PUBLIC_HEADER`/`PRIVATE_HEADER`,
right? If yes, then `install(TARGETS ... )` doesn't help us with installing headers and we
will be better off by just sticking with `install(FILES ...)`/`install(DIRECTORY ...)` for
headers.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message