mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [mesos] asekretenko commented on a change in pull request #363: CMake enable install module dependencies.
Date Thu, 28 May 2020 15:23:42 GMT

asekretenko commented on a change in pull request #363:
URL: https://github.com/apache/mesos/pull/363#discussion_r431922546



##########
File path: src/CMakeLists.txt
##########
@@ -675,6 +675,13 @@ install(
   RUNTIME DESTINATION ${MESOS_INSTALL_RUNTIME}
   ARCHIVE DESTINATION ${MESOS_INSTALL_LIBRARIES}
   LIBRARY DESTINATION ${MESOS_INSTALL_LIBRARIES})
+install(
+    DIRECTORY
+      ${CMAKE_SOURCE_DIR}/3rdparty/libprocess/include
+      ${CMAKE_SOURCE_DIR}/3rdparty/stout/include

Review comment:
       Looks like the proper locations for header install targets  are
   https://github.com/apache/mesos/blob/master/3rdparty/stout/CMakeLists.txt
   and
   https://github.com/apache/mesos/blob/master/3rdparty/libprocess/CMakeLists.txt
   accordingly
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message