mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 72456: Removed unecessary os::execlp wrapper.
Date Fri, 01 May 2020 05:26:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72456/#review220574
-----------------------------------------------------------


Ship it!




Ship It!

- Greg Mann


On April 30, 2020, 8:11 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72456/
> -----------------------------------------------------------
> 
> (Updated April 30, 2020, 8:11 p.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This wrapper is deleted on windows and just directly calls through
> to execlp on POSIX. The existing callsites don't prefix the call
> with os:: so we can remove this wrapper for now.
> 
> Also important to note is that we probably want to remove the other
> exec wrappers since on Windows they don't make much sense (requires
> emulating via a subprocess, can't directly exec like on POSIX).
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/os/posix/exec.hpp db57130470e1e50baebc5e940491a47ef3dd3d98

>   3rdparty/stout/include/stout/os/windows/exec.hpp 89db8af637dc6634c541a39a205d16d111e76953

> 
> 
> Diff: https://reviews.apache.org/r/72456/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message