mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 72391: Updated Docker containerizer to set Docker container's resource limits.
Date Fri, 01 May 2020 08:37:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72391/#review220576
-----------------------------------------------------------


Ship it!




Could you update the commit message to include some information about the particular use case
that this change is relevant for - custom executor Docker containers?

- Greg Mann


On April 30, 2020, 1:52 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72391/
> -----------------------------------------------------------
> 
> (Updated April 30, 2020, 1:52 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10054
>     https://issues.apache.org/jira/browse/MESOS-10054
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated Docker containerizer to set Docker container's resource limits.
> 
> 
> Diffs
> -----
> 
>   include/mesos/values.hpp 27f71d1e84f169e169e786372ed38e99be68e4ce 
>   src/common/values.cpp 75203824a1016eae7088bee19e61ee8cf8d3a660 
>   src/slave/containerizer/docker.hpp 09fc2795289e1292134b7d4bb2cc079c80d91c3d 
>   src/slave/containerizer/docker.cpp 492ac273fafb55d3e4c90d70fbf9c8c0c4fe7e70 
> 
> 
> Diff: https://reviews.apache.org/r/72391/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message