mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <>
Subject Re: Review Request 72368: Fixed a bug in the agent's draining handler.
Date Tue, 05 May 2020 05:22:52 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated May 5, 2020, 5:22 a.m.)

Review request for mesos, Andrei Sekretenko and Benjamin Mahler.

Bugs: MESOS-10118

Repository: mesos


Previously, when the agent had no tasks or operations and
received a `DrainSlaveMessage`, it would checkpoint the
`DrainConfig` to disk, implicitly placing it into a "draining"
state indefinitely. This patch updates the agent's handler to
avoid checkpointing anything to disk in this case.

The `SlaveTest.DrainInfoInAPIOutputs` test is also removed
and its functionality is moved into the test
`SlaveTest.DrainAgentKillsRunningTask`. The running task in
the latter test allows us to verify agent API outputs both
before and after the task's terminal update is acknowleged.

Diffs (updated)

  src/slave/slave.cpp 1a32c813eeacf21b903db3f9602d034e7fb085c0 
  src/tests/slave_tests.cpp 6b264d067accb9800ba75ea8f5d27c1e4c5593db 




Ran the test in with this patch applied and verified that
the final task reached TASK_RUNNING.


Greg Mann

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message