mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@mesosphere.io>
Subject Re: Review Request 72364: Added test for reactivation of a disconnected drained agent.
Date Tue, 05 May 2020 14:13:15 GMT


> On May 5, 2020, 5:41 a.m., Greg Mann wrote:
> > src/tests/master_draining_tests.cpp
> > Lines 239 (patched)
> > <https://reviews.apache.org/r/72364/diff/2/?file=2230159#file2230159line239>
> >
> >     Nit: s/lead to crash/lead to a crash/

Rewrote the comment to reflect the fact that this also tests for regression in MESOS-10118.


> On May 5, 2020, 5:41 a.m., Greg Mann wrote:
> > src/tests/master_draining_tests.cpp
> > Lines 319-324 (patched)
> > <https://reviews.apache.org/r/72364/diff/2/?file=2230159#file2230159line319>
> >
> >     Nit: it's a little weird to have one update use `TaskStatusUpdateStateEq` but
not the other? And both of these expectations use `WillRepeatedly`, but I think we could do
`WillOnce`.

Changed the first one to use a negated expectation, and removed `WillRepeatedly` from the
second one.


> On May 5, 2020, 5:41 a.m., Greg Mann wrote:
> > src/tests/master_draining_tests.cpp
> > Lines 368-370 (patched)
> > <https://reviews.apache.org/r/72364/diff/2/?file=2230159#file2230159line368>
> >
> >     I don't usually need to resume the clock to get a task running update to go
through, do you know exactly what's going on here?

Weird... after r72364 this test works without resuming the clock.

That's actually a good question why the task status update manager in this test was not being
resumed before your fix for MESOS-10118. I'm investigating that.


- Andrei


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72364/#review220617
-----------------------------------------------------------


On May 5, 2020, 2:05 p.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72364/
> -----------------------------------------------------------
> 
> (Updated May 5, 2020, 2:05 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Greg Mann.
> 
> 
> Bugs: MESOS-10116
>     https://issues.apache.org/jira/browse/MESOS-10116
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added test for reactivation of a disconnected drained agent.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_draining_tests.cpp f6b974f5f88f8563bd9cf6cca087b60cb5784e77 
> 
> 
> Diff: https://reviews.apache.org/r/72364/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message