mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@mesosphere.io>
Subject Re: Review Request 72364: Added test for reactivation of a disconnected drained agent.
Date Tue, 05 May 2020 17:16:03 GMT


> On May 5, 2020, 5:41 a.m., Greg Mann wrote:
> > src/tests/master_draining_tests.cpp
> > Lines 368-370 (patched)
> > <https://reviews.apache.org/r/72364/diff/2/?file=2230159#file2230159line368>
> >
> >     I don't usually need to resume the clock to get a task running update to go
through, do you know exactly what's going on here?
> 
> Andrei Sekretenko wrote:
>     Weird... after r72364 this test works without resuming the clock.
>     
>     That's actually a good question why the task status update manager in this test was
not being resumed before your fix for MESOS-10118. I'm investigating that.

For some reason, now I cannot reproduce the update manager being stuck in paused state. Neither
in the current configuration nor in the previous one.

Removed this `Clock::resume()`.


- Andrei


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72364/#review220617
-----------------------------------------------------------


On May 5, 2020, 2:05 p.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72364/
> -----------------------------------------------------------
> 
> (Updated May 5, 2020, 2:05 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Greg Mann.
> 
> 
> Bugs: MESOS-10116
>     https://issues.apache.org/jira/browse/MESOS-10116
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added test for reactivation of a disconnected drained agent.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_draining_tests.cpp f6b974f5f88f8563bd9cf6cca087b60cb5784e77 
> 
> 
> Diff: https://reviews.apache.org/r/72364/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message