mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Budnik <abud...@mesosphere.com>
Subject Re: Review Request 72475: Logged connection error message before shutting down the executor.
Date Wed, 06 May 2020 17:46:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72475/
-----------------------------------------------------------

(Updated Май 6, 2020, 5:46 п.п.)


Review request for mesos, Andrei Sekretenko, Benjamin Mahler, Greg Mann, and Qian Zhang.


Summary (updated)
-----------------

Logged connection error message before shutting down the executor.


Repository: mesos


Description (updated)
-------

Previously, if an executor failed to connect to the agent, it would
silently shutdown itself without writing an error message to the log.
After we added the support for the domain sockets, a set of potential
failures during `connect` increased. In this patch, we logged
the connection failures to help in debugging.


Diffs (updated)
-----

  src/executor/executor.cpp 213f38ed9217144f32f9eeb2ef22afb054279d9b 


Diff: https://reviews.apache.org/r/72475/diff/2/

Changes: https://reviews.apache.org/r/72475/diff/1-2/


Testing
-------

None: not a functional change.


Thanks,

Andrei Budnik


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message