mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 72494: Added tests to cmake install target.
Date Tue, 12 May 2020 18:36:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72494/#review220716
-----------------------------------------------------------




cmake/CompilationConfigure.cmake
Lines 72 (patched)
<https://reviews.apache.org/r/72494/#comment309399>

    Should this be documented somewhere?



cmake/CompilationConfigure.cmake
Lines 73 (patched)
<https://reviews.apache.org/r/72494/#comment309361>

    s/tests/test/
    
    s/dependences/dependencies/


- Greg Mann


On May 11, 2020, 7:35 p.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72494/
> -----------------------------------------------------------
> 
> (Updated May 11, 2020, 7:35 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Bugs: MESOS-6771
>     https://issues.apache.org/jira/browse/MESOS-6771
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added tests to cmake install target.
> 
> 
> Diffs
> -----
> 
>   cmake/CompilationConfigure.cmake f9511fc46e87d0bd27fb01fabc674d0ee0799c07 
>   src/examples/CMakeLists.txt a811a070f0fa1e313b1c651c7df955595127d767 
>   src/tests/CMakeLists.txt 9d5ce02c0037f9cfe9c5a9480faea7539907c937 
>   src/tests/agent_resource_provider_config_api_tests.cpp aadebd3477f9207280e55f36f6f896da3b4fddf2

>   src/tests/default_executor_tests.cpp 2353520c30066e04aa96b4b24134b6163e87d84f 
>   src/tests/storage_local_resource_provider_tests.cpp 568683afad0545397366a551b006634f2030ae33

> 
> 
> Diff: https://reviews.apache.org/r/72494/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message