mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 72516: Erased `Info` struct before unmouting volumes in Docker volume isolator.
Date Fri, 15 May 2020 14:47:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72516/#review220784
-----------------------------------------------------------



Patch looks great!

Reviews applied: [72516]

Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1';
./support/jenkins/buildbot.sh

- Mesos Reviewbot


On May 15, 2020, 12:41 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72516/
> -----------------------------------------------------------
> 
> (Updated May 15, 2020, 12:41 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10126
>     https://issues.apache.org/jira/browse/MESOS-10126
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Currently when `DockerVolumeIsolatorProcess::cleanup()` is called, we will
> unmount the volume first, and if the unmount operation fails we will NOT
> erase the container's `Info` struct from `infos`. This is problematic
> because the remaining `Info` in `infos` will cause the reference count of
> the volume is greater than 0, but actually the volume is not being used by
> any containers. That means we may never get a chance to unmount this volume
> on this agent, furthermore if it is an EBS volume, it cannot be used by any
> tasks launched on any other agents since a EBS volume can only be attached
> to one node at a time. The only workaround would manually unmount the volume.
> 
> So in this patch `DockerVolumeIsolatorProcess::cleanup()` is updated to erase
> container's `Info` struct before unmounting volumes.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp c547696f50a4df9cce4ee9078b5fe90b93fd91d2

> 
> 
> Diff: https://reviews.apache.org/r/72516/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message