mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@mesosphere.io>
Subject Re: Review Request 72547: Fixed missing protoc dependencies of compiled protobufs.
Date Wed, 27 May 2020 17:08:36 GMT


> On May 27, 2020, 4:49 p.m., Benjamin Mahler wrote:
> > src/Makefile.am
> > Lines 259 (patched)
> > <https://reviews.apache.org/r/72547/diff/3/?file=2233359#file2233359line259>
> >
> >     What goes wrong if we were to use GRPC_CPP_PLUGIN and PROTOC rather than the
extra level of indirection with GRPC_CPP_PLUGIN_TARGET / PROTOC_TARGET?
> >     
> >     Seems like it would work as a dependency below, is that not the case?

This would result in `make` treating the system protobuf compiler (or the protobuf compiler
specified via `--with-protobuf=DIR` configure option) as a dependency.
Given that `--with-protobuf` should point to a directory (and not to some weird thing that
could be interpreted by shell, but is not interpreted by make), everything should work.

This will be somewhat inconsistent when compared to what happens when one, for example, touches
the system C++ compiler, but should not cause problems.


- Andrei


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72547/#review220889
-----------------------------------------------------------


On May 27, 2020, 3:12 p.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72547/
> -----------------------------------------------------------
> 
> (Updated May 27, 2020, 3:12 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Benjamin Mahler, Greg Mann, Qian Zhang, and
Vinod Kone.
> 
> 
> Bugs: MESOS-10135
>     https://issues.apache.org/jira/browse/MESOS-10135
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds dependencies onto `protoc` and the GRPC C++ plugin
> to the `*pb.h` / `*.pb.cc` targets.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 0b18f958bd5fb17ebada76c9445ca2768ab1ef5c 
> 
> 
> Diff: https://reviews.apache.org/r/72547/diff/3/
> 
> 
> Testing
> -------
> 
> Built in internal CI on several different platforms.
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message