metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nickwallen <...@git.apache.org>
Subject [GitHub] incubator-metron pull request: METRON-43: Refactor Deployment Scri...
Date Tue, 23 Feb 2016 12:34:45 GMT
Github user nickwallen commented on the pull request:

    https://github.com/apache/incubator-metron/pull/28#issuecomment-187681809
  
    Why pull all variables, even those unlikely to change, up to the inventory level?  For
example, why define `metron_jar_name` in `deployment/inventory/singlenode-vagrant/group_vars/all`?

    
    Previously these sorts of vars were pushed down into the role itself.  The logic being
that these will rarely change and that the user need not worry about them.  For example, `metron_jar_name`
is defined in `incubator-metron/deployment/roles/metron_streaming/vars/main.yml`.  



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message