metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nickwallen <...@git.apache.org>
Subject [GitHub] incubator-metron pull request: METRON-59 Fully automated, push-but...
Date Tue, 08 Mar 2016 18:16:27 GMT
GitHub user nickwallen opened a pull request:

    https://github.com/apache/incubator-metron/pull/40

    METRON-59 Fully automated, push-button deployment of Metron to Amazon EC2

    This PR makes it stupid-simple to deploy Metron on Amazon EC2.  Follow the instructions
in `deployment/amazon-ec2/README.md` to get started.  
    
    The following checks have been performed.
    
    - [x] Full deployment to Amazon EC2
    - [x] Integration Tests `cd metron-streaming; mvn integration-test`
    - [x] License Checks `mvn apache-rat:check`
    
    I have only a few reservations about this PR.  I would love to get feedback on these.
 Fundamentally, this PR uses dynamic host definitions whereas much of the existing Ansible
code uses static host definitions.  This has made it difficult to reuse some of the existing
code. 
    
    - I was not able to reuse the variable definitions in `deployment/inventory`.  Most of
the variables in `deployment/amazon-ec2/conf/defaults.yml` are duplicative. Specifically lines
25-70.
    
    - I was also not able to to reuse the playbooks in `deployment/amazon-ec2/playbooks`.
I needed to include the vars, mentioned above, by adding the following to each set of host
tasks.  What this means is that `deployment/amazon-ec2/playbook.yml` from line 49-177 had
to be mostly duplicated.  
    
    ```  
    vars_files:
        - conf/defaults.yml 
    ```
    
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nickwallen/incubator-metron METRON-59

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-metron/pull/40.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #40
    
----
commit b5c7c28b80c4b2f5c0bb773379f7fc43ee02c315
Author: Nick Allen <nick@nickallen.org>
Date:   2016-03-08T17:49:36Z

    METRON-59 Fully automated, push-button deployment of Metron to Amazon EC2

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message