metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dlyle65535 <...@git.apache.org>
Subject [GitHub] incubator-metron pull request: Metron 86 - SolrWriter
Date Tue, 05 Apr 2016 12:34:30 GMT
Github user dlyle65535 commented on a diff in the pull request:

    https://github.com/apache/incubator-metron/pull/67#discussion_r58529502
  
    --- Diff: metron-streaming/Metron-Solr/src/main/java/org/apache/metron/writer/solr/SolrWriter.java
---
    @@ -65,7 +71,9 @@ public void write(String sourceType, Configurations configurations,
List<Tuple>
           }
           UpdateResponse response = solr.add(document);
         }
    -    solr.commit(getCollection(configurations));
    +    if (shouldCommit) {
    +      solr.commit(getCollection(configurations));
    +    }
       }
    --- End diff --
    
    There may be a little more work to do on this. I ran it up last night and after 1/2 an
hour had to issue a manual commit to see any documents in Solr. IIRC, openSearcher is false
by default which would explain that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message