metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nickwallen <...@git.apache.org>
Subject [GitHub] incubator-metron pull request #133: METRON-180 Granular Control of Component...
Date Tue, 07 Jun 2016 12:37:21 GMT
Github user nickwallen commented on a diff in the pull request:

    https://github.com/apache/incubator-metron/pull/133#discussion_r66062033
  
    --- Diff: metron-deployment/playbooks/metron_install.yml ---
    @@ -74,47 +83,115 @@
       tags:
         - mysql-client
     
    -- hosts: sensors
    -  become: true
    -  roles:
    -    - ambari_gather_facts
    -    - { role: tap_interface, when: install_tap | default(False) == True }
    -    - { role: pycapa, when: install_pycapa | default(True) == True }
    -    - { role: bro, when: install_bro | default(True) == True }
    -    - { role: flume,  when: install_snort | default(True) == True }
    -    - { role: snort , when: install_snort | default(True) == True }
    -    - { role: yaf, when: install_yaf | default(True) == True }
    -    - { role: pcap_replay, when: install_pcap_replay | default(False) == True }
    -    - { role: sensor-test-mode, when: sensor_test_mode | default(False) == True }
    -  tags:
    -      - sensors
    -
    +#
    +# parsers, enrichment, and indexing topologies
    +#
     - hosts: enrichment
       become: true
       roles:
         - role: metron_streaming
       tags:
         - enrichment
     
    +#
    +# user interface
    +#
     - hosts: pcap_server
       become: true
       roles:
    -    - { role: metron_pcapservice, when: install_elasticsearch | default(True) == True
}
    +    - role: metron_pcapservice
       tags:
    -    - pcap_service
    +    - pcap-service
     
     - hosts: web
       become: true
       roles:
    -    - { role: kibana, when: install_elasticsearch | default(True) == True }
    +    - role: kibana
       tags:
    -    - web
    +    - kibana
     
    +#
    +# sensors
    +#
    +- hosts: sensors
    +  become: true
    +  roles:
    +    - role: ambari_gather_facts
    +    - role: tap_interface
    +  tags:
    +    - tap
    +
    +- hosts: sensors
    +  become: true
    +  roles:
    +    - role: ambari_gather_facts
    +    - role: pycapa
    +  tags:
    +    - pycapa
    +
    +- hosts: sensors
    +  become: true
    +  roles:
    +    - role: ambari_gather_facts
    +    - role: bro
    +  tags:
    +    - bro
    +
    +- hosts: sensors
    +  become: true
    +  roles:
    +    - role: ambari_gather_facts
    +    - role: flume
    +  tags:
    +    - flume
    +
    +- hosts: sensors
    +  become: true
    +  roles:
    +    - role: ambari_gather_facts
    +    - role: snort
    +  tags:
    +    - snort
    +
    +- hosts: sensors
    +  become: true
    +  roles:
    +    - role: ambari_gather_facts
    +    - role: yaf
    +  tags:
    +    - yaf
    +
    +- hosts: sensors
    +  become: true
    +  roles:
    +    - role: ambari_gather_facts
    +    - role: pcap_replay
    +  tags:
    +    - pcap-replay
    +
    +- hosts: sensors
    +  become: true
    +  roles:
    +    - role: ambari_gather_facts
    +    - role: sensor-test-mode
    +  tags:
    +    - sensor-test-mode
    +
    --- End diff --
    
    Those changes tested successfully.  Added those in.  Good suggestion.  Much better looking.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message