metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nickwallen <...@git.apache.org>
Subject [GitHub] incubator-metron pull request #144: METRON-211 Enable creation of new Kafka ...
Date Tue, 07 Jun 2016 14:40:46 GMT
Github user nickwallen commented on a diff in the pull request:

    https://github.com/apache/incubator-metron/pull/144#discussion_r66083599
  
    --- Diff: metron-deployment/roles/metron_streaming/tasks/main.yml ---
    @@ -15,25 +15,18 @@
     #  limitations under the License.
     #
     ---
    -- name: Create Metron streaming directories
    -  file: path="{{ metron_directory }}/{{ item.name }}"  state=directory mode=0755
    +- name: Create Metron directories
    +  file: path={{ metron_directory }}/{{ item }} state=directory mode=0755
       with_items:
    -      - { name: 'lib'}
    -      - { name: 'bin'}
    -      - { name: 'config'}
    +      - lib
    +      - bin
    +      - config
     
     - name: Create Source Config Directory
    -  file:
    -    path: "{{ zookeeper_config_path }}"
    -    state: directory
    -    mode: 0755
    +  file: path={{ zookeeper_config_path }} state=directory mode=0755
    --- End diff --
    
    Reverted to original vertical presentation. Not a good enough reason for me to change
it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message