metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cestella <...@git.apache.org>
Subject [GitHub] incubator-metron pull request #156: METRON-235 Expose filtering capability f...
Date Thu, 16 Jun 2016 20:54:22 GMT
Github user cestella commented on a diff in the pull request:

    https://github.com/apache/incubator-metron/pull/156#discussion_r67422117
  
    --- Diff: metron-platform/metron-pcap-backend/src/main/java/org/apache/metron/pcap/query/CliParser.java
---
    @@ -0,0 +1,83 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.metron.pcap.query;
    +
    +import org.apache.commons.cli.CommandLine;
    +import org.apache.commons.cli.HelpFormatter;
    +import org.apache.commons.cli.Option;
    +import org.apache.commons.cli.Options;
    +
    +/**
    + * Provides commmon required fields for the PCAP filter jobs
    + */
    +public class CliParser {
    +
    +  public Options buildOptions() {
    +    Options options = new Options();
    +    options.addOption(newOption("h", false, "Display help"));
    +    options.addOption(newOption("basePath", true, String.format("Base PCAP data path.
Default is '%s'", CliConfig.BASE_PATH_DEFAULT)));
    +    options.addOption(newOption("baseOutputPath", true, String.format("Query result output
path. Default is '%s'", CliConfig.BASE_OUTPUT_PATH_DEFAULT)));
    +    options.addOption(newOption("startTime", true, "Packet start time range. Default
is '0'"));
    --- End diff --
    
    Can we specify a date format to use to parse the start and end times?  I suspect that's
a useful piece of sugar as it would require people to not have to look up the epoch time translation
every time they want to run this for a time range.  I'd just pass an arg with the date format
to use.  If it's not specified, then assume epoch time.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message