metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cestella <...@git.apache.org>
Subject [GitHub] incubator-metron pull request #188: METRON-227 (Time based flushing)
Date Wed, 13 Jul 2016 20:43:14 GMT
Github user cestella commented on a diff in the pull request:

    https://github.com/apache/incubator-metron/pull/188#discussion_r70704522
  
    --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/writer/BulkWriterComponent.java
---
    @@ -103,10 +115,21 @@ public void write( String sensorType
         }
         messageList.add(message);
     
    -    if (tupleList.size() < batchSize) {
    -      sensorTupleMap.put(sensorType, tupleList);
    -      sensorMessageMap.put(sensorType, messageList);
    -    } else {
    +    if(configurations.getGlobalConfig()!=null&&configurations.getGlobalConfig().get(Constants.TIME_FLUSH_FLAG)!=null)
    --- End diff --
    
    I'd recommend saving off the global config in a member variable and reusing that reference.
 It's possible the configuration will get updated between calls to `configurations.getGlobalConfig()`
in zookeeper and therefore you'll get two separate configs.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message