metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mmiklavc <...@git.apache.org>
Subject [GitHub] incubator-metron pull request #189: Metron-302 Build Common Deployment RPM
Date Thu, 14 Jul 2016 13:52:24 GMT
Github user mmiklavc commented on a diff in the pull request:

    https://github.com/apache/incubator-metron/pull/189#discussion_r70808062
  
    --- Diff: metron-deployment/packaging/docker/rpm-docker/build.sh ---
    @@ -0,0 +1,6 @@
    +#!/bin/bash
    +
    +rm -rf SRPMS/ RPMS/ && \
    +rpmbuild -v -ba --define "_topdir $(pwd)" --define "_version 0.2.0BETA" SPECS/metron.spec
&& \
    +rpmlint -i SPECS/metron.spec RPMS/*/metron* SRPMS/metron
    --- End diff --
    
    rpmlint checks the spec files as well as the RPM's themselves - I'd recommend keeping
it for verification that we:
    1. follow RPM standards
    2. don't have errors (RPM can build with error code 0, but have actual issues for installation)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message