metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nickwallen <...@git.apache.org>
Subject [GitHub] incubator-metron pull request #210: METRON-366: Add MODEL_APPLY to Stellar
Date Fri, 19 Aug 2016 19:06:43 GMT
Github user nickwallen commented on a diff in the pull request:

    https://github.com/apache/incubator-metron/pull/210#discussion_r75536146
  
    --- Diff: metron-analytics/metron-maas-common/src/main/java/org/apache/metron/maas/discovery/ServiceDiscoverer.java
---
    @@ -93,6 +116,7 @@ private void updateState() {
             }
           }
           rwLock.writeLock().lock();
    +      this.modelToCurrentVersion = modelToVersion;
           this.state = state;
           this.containerToEndpoint = containerToEndpoint;
           rwLock.writeLock().unlock();
    --- End diff --
    
    There are a few other places where locks are used without try/finally.  For example in
blacklist(...) and getEndpoint(...). May need to hit those up too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message