metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nickwallen <...@git.apache.org>
Subject [GitHub] incubator-metron pull request #236: METRON-389 Create Java API to Read Profi...
Date Mon, 12 Sep 2016 13:15:53 GMT
Github user nickwallen commented on a diff in the pull request:

    https://github.com/apache/incubator-metron/pull/236#discussion_r78369468
  
    --- Diff: metron-analytics/metron-profiler/src/main/java/org/apache/metron/profiler/bolt/ProfileBuilderBolt.java
---
    @@ -194,8 +194,8 @@ private void init(Tuple input) {
           expressions.forEach((var, expr) -> executor.assign(var, expr, message));
     
         } catch(ParseException e) {
    -      String msg = format("Bad 'init' expression: %s, profile=%s, entity=%s, start=%d",
    -              e.getMessage(), measurement.getProfileName(), measurement.getEntity(),
measurement.getStart());
    +      String msg = format("Bad 'init' expression: %s, profile=%s, entity=%s",
    +              e.getMessage(), measurement.getProfileName(), measurement.getEntity());
    --- End diff --
    
    Yes, they already are LOG.error'd inside `execute`.  
    
    The point of this catch is to add the extra note that the failure came from the 'init'
expression, rather than one of the other expressions involved in creating a profile.  I wanted
to make it blatantly obvious to the user which expression failed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message