metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nickwallen <...@git.apache.org>
Subject [GitHub] incubator-metron pull request #236: METRON-389 Create Java API to Read Profi...
Date Mon, 12 Sep 2016 13:37:04 GMT
Github user nickwallen commented on a diff in the pull request:

    https://github.com/apache/incubator-metron/pull/236#discussion_r78373523
  
    --- Diff: metron-analytics/metron-profiler/src/main/java/org/apache/metron/profiler/hbase/Serializer.java
---
    @@ -0,0 +1,92 @@
    +/*
    + *
    + *  Licensed to the Apache Software Foundation (ASF) under one
    + *  or more contributor license agreements.  See the NOTICE file
    + *  distributed with this work for additional information
    + *  regarding copyright ownership.  The ASF licenses this file
    + *  to you under the Apache License, Version 2.0 (the
    + *  "License"); you may not use this file except in compliance
    + *  with the License.  You may obtain a copy of the License at
    + *
    + *      http://www.apache.org/licenses/LICENSE-2.0
    + *
    + *  Unless required by applicable law or agreed to in writing, software
    + *  distributed under the License is distributed on an "AS IS" BASIS,
    + *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + *  See the License for the specific language governing permissions and
    + *  limitations under the License.
    + *
    + */
    +
    +package org.apache.metron.profiler.hbase;
    +
    +import org.apache.hadoop.hbase.util.Bytes;
    +
    +/**
    + * Provides basic functionality to serialize and deserialize the allowed
    + * value types for a ProfileMeasurement.
    + */
    +public class Serializer {
    +
    +  private Serializer() {
    +    // do not instantiate
    +  }
    +
    +  /**
    +   * Serialize a profile measurement's value.
    +   *
    +   * The value produced by a Profile definition can be any numeric data type.  The data
    +   * type depends on how the profile is defined by the user.  The user should be able
to
    +   * choose the data type that is most suitable for their use case.
    +   *
    +   * @param value The value to serialize.
    +   */
    +  public static byte[] toBytes(Object value) {
    --- End diff --
    
    Yes, I like that.  I went down this path before, but ran into some unrelated issues and
ended up unwinding the change.  There are at least 4 touch points that would change based
on this; all good changes.
    
    Wondering if I should just submit this change as a separate PR to make my life easier
with the other dependent changes I have in the pipeline.  Looking at the code now  to see
how painful that might be.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message