metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nickwallen <...@git.apache.org>
Subject [GitHub] incubator-metron issue #250: METRON-416: Provide the ability to store mergea...
Date Wed, 14 Sep 2016 13:29:28 GMT
Github user nickwallen commented on the issue:

    https://github.com/apache/incubator-metron/pull/250
  
    I don't see any unit tests that check for correct handling of overflow or underflow. 
Am I missing them?
    
    I modified the tests to see what happens and when you actually hit an overflow condition.
 The code correctly detects it from what I can tell, but there is no indication that it occurred.
 Similar to METRON-404, but not during function initialization.  The exception gets swallowed
and all you see is "ParseException: Unable to pop an empty stack".  Could be addressed as
a separate PR, but worthy of a fixin.  
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message