metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cestella <>
Subject [GitHub] incubator-metron pull request #251: METRON-418 Set TTL on HBase Puts
Date Thu, 15 Sep 2016 15:59:55 GMT
Github user cestella commented on a diff in the pull request:
    --- Diff: metron-analytics/metron-profiler-client/src/test/java/org/apache/metron/profiler/client/
    @@ -92,8 +92,8 @@ private void write(ProfileMeasurement m, List<Object> groups)
         byte[] rowKey = rowKeyBuilder.rowKey(m, groups);
         ColumnList cols = columnBuilder.columns(m);
    -    List<Mutation> mutations = hbaseClient.constructMutationReq(rowKey, cols, Durability.SKIP_WAL);
    -    hbaseClient.batchMutate(mutations);
    +    hbaseClient.addMutation(rowKey, cols, Durability.SKIP_WAL);
    --- End diff --
    I don't think you want to `SKIP_WAL`  That will result in data loss on region server crash.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message