metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nickwallen <>
Subject [GitHub] incubator-metron pull request #246: METRON-411 Support Greater Range of Prof...
Date Sat, 10 Sep 2016 02:32:50 GMT
GitHub user nickwallen opened a pull request:

    METRON-411 Support Greater Range of Profile Periods 

    Depends on existing pull requests #236 #237 and #242 .  The diff might look a little wonky
until those other PRs are merged.
    ### Problem
    The current Profiler's deterministic row key design limits the range of profile period
durations available to a user.  The original goal was to support 15 minute periods which it
does, along with 5, 20, 30 and 60 minute periods.  Different types of profiles and input data
will require a range of periods and the Profiler should be flexible in this regard.
    Currently, a profile period must start on each and every hour.  While 1, 2, 3, 4, 6, or
240 periods per hour is acceptable, 5 periods per hour is not.  The number of periods per
hour must be either a multiple or divisor of 60.  Also, a period cannot be any longer than
an hour.  In some cases 2, 4, or 8 hour periods might be useful.
    ### Solution
    This change uses a much simpler method of calculating row keys and allows the user to
set the  specific duration of each profile period.  Based on this duration, each period starting
at the epoch, is assigned a monotonically increasing value which is used as part of the row
key.  Periods can span multiple hours and there is no arbitrary durations that are unacceptable,
like 5 periods per hour.

You can merge this pull request into a Git repository by running:

    $ git pull METRON-411

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #246
commit 444bfb41fc872194c1fbbf9820248f85c5066c51
Author: Nick Allen <>
Date:   2016-08-23T17:03:15Z

    METRON-389 Create Java API to Read Profile Data During Model Scoring

commit 3bb55c63f70d1493df0dbd70fd548ec8b6ce3030
Author: Nick Allen <>
Date:   2016-08-30T01:23:03Z

    METRON-389 Missed removal of old tests during merge

commit 71b50c293ed896d948bc63cbc40d370bdc2b003a
Author: Nick Allen <>
Date:   2016-08-30T01:31:55Z

    METRON-389 Change to Context was lost in merge

commit b9e017c1101fb3a67435d3462234870bf0ed9717
Author: Nick Allen <>
Date:   2016-08-30T13:23:56Z

    METRON-389 Was missing changes from METRON-377

commit 1ddeb24087729692ec502a4108bf04b655c235cb
Author: Nick Allen <>
Date:   2016-08-30T13:27:36Z

    METRON-389 Removed unnecessary commented-out code

commit 4af9b196bc4012162bc5cc3758a09c50321feccd
Author: Nick Allen <>
Date:   2016-08-30T13:46:10Z

    METRON-389 Made sure the docs are consistent; periodsPerHour can be a multiple or divisor
of 60.

commit ee4c5145536c4e97360381cd8b8a7bf6bd65db1b
Author: Nick Allen <>
Date:   2016-08-30T14:01:20Z

    METRON-389 Was missing updated test from METRON-377

commit 155a08715939ad99892ec18c884f6124495c9434
Author: Nick Allen <>
Date:   2016-08-30T16:42:04Z

    METRON-399 Stellar Date Functions Should Default to Current Time

commit ed4700074e57e0cea701530befabd658d28be64e
Author: cstella <>
Date:   2016-08-26T17:21:13Z

    METRON-396: Make Stellar function resolution happen via an annotation and classpath search

commit 7b471c94ac82863f02ed081999855072349167dc
Author: Nick Allen <>
Date:   2016-09-02T18:09:36Z

    METRON-391 Refactor so HBaseProfileClient does not refer to static fields which causes
unnecessary dependency

commit 1135c4261c7a8e5e5b74a7b88b33e982e4eb2ebf
Author: Nick Allen <>
Date:   2016-09-02T18:10:56Z

    METRON-391 Create Stellar Function to Read Profile Data for Model Scoring

commit b19b9dcffed7a608d092bb289a8867ae9810977a
Author: Nick Allen <>
Date:   2016-09-02T19:51:26Z

    METRON-404 Stellar Compiler Hides Function Initialization Errors

commit f75ce385cf707756913478c4b7cfb47c4e3753ea
Author: Nick Allen <>
Date:   2016-09-06T17:04:03Z

    METRON-391 Improved examples

commit 75f996757dd9b9730a1dd563d28ae3d97aec57a6
Author: Nick Allen <>
Date:   2016-09-06T19:37:21Z

    METRON-391 Rename of ProfileWriter

commit 40893167a00fda6ceb8b3ca665d85ffbaaf1f83a
Author: Nick Allen <>
Date:   2016-09-06T20:03:52Z

    Merge 'apache/master' into METRON-391

commit 008f6f23b9b1b8b997a4ce1d9f1e92302a975ce5
Author: Nick Allen <>
Date:   2016-09-06T20:19:47Z

    Still need to call initialize which was lost in the merge

commit 34382290cd8aeb5eb7ba3abab42319ddf0f5644f
Author: Nick Allen <>
Date:   2016-09-07T19:03:28Z

    Merge remote-tracking branch 'apache/master' into METRON-391

commit 97599d69e703829ea823625b0a79a408c3e861ce
Author: Nick Allen <>
Date:   2016-09-07T19:30:02Z

    METRON-391 Removed unnecessary code from test

commit 38a3619b5f4a84219b03ed99316d7e423f2acbcf
Author: Nick Allen <>
Date:   2016-09-07T19:47:37Z

    METRON-391 Renamed to reset() and added docs

commit 9a7d67f66ef1c57aa516ee0281019864f2b3a5b9
Author: Nick Allen <>
Date:   2016-09-08T12:21:01Z

    METRON-391 Fixed README from bad merge

commit fa14f2b0747e6c802673e909a7b90d48726c18ab
Author: Nick Allen <>
Date:   2016-09-09T13:39:44Z

    METRON-391 Improved docs

commit d677c6a539e7a113e12a78272a1ce282d03284dc
Author: Nick Allen <>
Date:   2016-09-10T02:10:03Z

    METRON-411 Support Greater Range of Profile Periods


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message