metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kylerichardson <...@git.apache.org>
Subject [GitHub] incubator-metron pull request #276: METRON-363 Fix Cisco ASA Parser
Date Sat, 01 Oct 2016 17:39:07 GMT
Github user kylerichardson commented on a diff in the pull request:

    https://github.com/apache/incubator-metron/pull/276#discussion_r81454727
  
    --- Diff: metron-deployment/roles/metron_kafka_topics/defaults/main.yml ---
    @@ -21,6 +21,7 @@ topics_to_create:
       - { topic: "bro",         num_partitions: 1, replication_factor: 1, retention_gb: 10
}
       - { topic: "yaf",         num_partitions: 1, replication_factor: 1, retention_gb: 10
}
       - { topic: "snort",       num_partitions: 1, replication_factor: 1, retention_gb: 10
}
    +  - { topic: "asa", num_partitions: 1, replication_factor: 1, retention_gb: 10 }
    --- End diff --
    
    That makes sense. I was thinking about building out the monit scripts, etc to make this
as easy as possible for the user to deploy out-of-the-box, but that's a future PR. Is that
something that would be valuable to folks? Either way, I can remove this from the current
PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message