metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cestella <...@git.apache.org>
Subject [GitHub] incubator-metron issue #293: METRON-473 Add LENGTH() To Stellar
Date Thu, 06 Oct 2016 18:59:07 GMT
Github user cestella commented on the issue:

    https://github.com/apache/incubator-metron/pull/293
  
    So, yes, a couple of things need to be ensured for stellar functions:
    * The output of the call is serializable via kryo (the profiler stores the output of stellar
statements in HBase)
    * It passes the `validate` call
    
    Validate is intended to check syntactic errors and it does so by passing a VariableResolver
that returns null for every variable.  I will admit that I've been thinking this should be
rethought and we should do this another way:
    * Have a special implementation of StellarBaseListener that barfs if function resolution
happens, but doesn't actually apply functions
    * Uses the normal Stellar Lexer to ensure syntactic errors
    This should ensure that the stellar statement is valid syntactically IMO.
    
    Thoughts?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message