metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From james-sirota <...@git.apache.org>
Subject [GitHub] incubator-metron pull request #276: METRON-363 Fix Cisco ASA Parser
Date Fri, 07 Oct 2016 18:39:00 GMT
Github user james-sirota commented on a diff in the pull request:

    https://github.com/apache/incubator-metron/pull/276#discussion_r82446542
  
    --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/Constants.java
---
    @@ -43,6 +43,7 @@
         ,DST_PORT("ip_dst_port")
         ,PROTOCOL("protocol")
         ,TIMESTAMP("timestamp")
    +    ,ORIGINAL("original_string")
    --- End diff --
    
    I agree. I think we've needed something like this for a while. it will help standardize
our parsing. great job noticing this.  I am definitely +1 on refactoring grok to look like
this 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message