metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kylerichardson <...@git.apache.org>
Subject [GitHub] incubator-metron pull request #276: METRON-363 Fix Cisco ASA Parser
Date Sat, 08 Oct 2016 00:28:57 GMT
Github user kylerichardson commented on a diff in the pull request:

    https://github.com/apache/incubator-metron/pull/276#discussion_r82489921
  
    --- Diff: metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/utils/SyslogUtils.java
---
    @@ -0,0 +1,89 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.metron.parsers.utils;
    +
    +import java.time.ZoneOffset;
    +import java.time.ZonedDateTime;
    +import java.time.format.DateTimeFormatter;
    +
    +public class SyslogUtils {
    +
    +    public static long convertToEpochMillis(String logTimestamp, String logTimeFormat)
{
    +        ZonedDateTime timestamp = ZonedDateTime.parse(logTimestamp, DateTimeFormatter.ofPattern(logTimeFormat).withZone(ZoneOffset.UTC));
    +        return timestamp.toEpochSecond() * 1000;
    +    }
    +
    +    public static long parseTimestampToEpochMillis(String logTimestamp) {
    +        if (logTimestamp.length() < 20) {
    +            ZonedDateTime now = ZonedDateTime.now(ZoneOffset.UTC);
    --- End diff --
    
    Of course you're right, the timestamp will not always be in UTC. ASA logs consumed via
syslog (either raw off the wire or through another syslog server) will generally follow the
syslog standard.
    
    There are a number of possibilities to explore here. If we assume that we will be collecting
the raw syslog from the ASAs off the wire, the timestamp will not include the timezone/offset.
This code assumes the device is logging in UTC, which, to your point, is probably a bad assumption.
I made this assumption because it seems to me we would want all of the timestamps indexed
to be in the same timezone and the easiest way to accomplish that would be to normalize all
of the telemetry data to UTC.
    
    Question for the team. How are other parsers handling timezone? Are they passing through
the device timezone?
    
    The way I'm thinking of solving this is by adding a configuration option to the parser
to specify the device timezone. (This would require that all ASAs put through the parser we
configured to the same timezone though.) I would then convert the timestamp to UTC prior to
writing it into the metron normalized JSON message.
    
    Any feedback or other ideas on solving this one?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message