metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From merrimanr <...@git.apache.org>
Subject [GitHub] incubator-metron pull request #324: METRON-515: Stellar IS_EMPTY() function ...
Date Thu, 27 Oct 2016 19:21:49 GMT
GitHub user merrimanr reopened a pull request:

    https://github.com/apache/incubator-metron/pull/324

    METRON-515: Stellar IS_EMPTY() function does not work as expected

    The "IS_EMPTY" Stellar function is always returning true if the field value is not a String
type.  This PR changes the function to only return true when a value is missing, an empty
string, or has a null value.  
    
    I also modified the unit test to include a test for an Integer type and removed the test
that asserts true when the value is a newly created object.  In my opinion that is not a valid
test case.  

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/merrimanr/incubator-metron METRON-515

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-metron/pull/324.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #324
    
----
commit 3847ad828c4069cecba70667fd3662f4f5507e89
Author: rmerriman <rmerriman@hortonworks.com>
Date:   2016-10-25T18:39:59Z

    Now handles other types besides String

commit a9f6538f48bf43cd1f725258ae619b056c9ef17c
Author: rmerriman <rmerriman@hortonworks.com>
Date:   2016-10-26T14:35:42Z

    Updated docs to reflect change

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message