metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nickwallen <...@git.apache.org>
Subject [GitHub] incubator-metron pull request #323: METRON-514: Snort kafka topic fails to g...
Date Mon, 31 Oct 2016 18:03:54 GMT
Github user nickwallen commented on a diff in the pull request:

    https://github.com/apache/incubator-metron/pull/323#discussion_r85796965
  
    --- Diff: metron-deployment/roles/yaf/tasks/yaf.yml ---
    @@ -48,7 +48,3 @@
     
     - name: Install init.d service script
       template: src=yaf dest=/etc/init.d/yaf mode=0755
    -
    --- End diff --
    
    Sorry, late to the party. Had to expand the 'thingie' to see that prior conversation.
  
    
    If I remember correctly, the original reason that was added was because if you just deploy
and then run 'service yaf start' on CentOS 7, Systemd would fail the service immediately.
 Doing the `enable` made Systemd aware of the older SysV script, so that when we start it
later in the deployment, it works.  
    
    But this was probably not the best way to do it, as this has the effect of starting the
service on boot, which is not what we want.  
    
    I'm good with taking this out (as you have it), since your testing has been successful
without it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message